Messages in this thread | | | Subject | Re: [PATCH 04/33] readahead: page flag PG_readahead | From | Peter Zijlstra <> | Date | Wed, 24 May 2006 14:48:48 +0200 |
| |
On Wed, 2006-05-24 at 20:37 +0800, Wu Fengguang wrote: > On Wed, May 24, 2006 at 02:27:36PM +0200, Peter Zijlstra wrote: > > On Wed, 2006-05-24 at 19:12 +0800, Wu Fengguang wrote:
> > > --- linux-2.6.17-rc4-mm3.orig/include/linux/page-flags.h > > > +++ linux-2.6.17-rc4-mm3/include/linux/page-flags.h > > > @@ -89,6 +89,7 @@ > > > #define PG_reclaim 17 /* To be reclaimed asap */ > > > #define PG_nosave_free 18 /* Free, should not be written */ > > > #define PG_buddy 19 /* Page is free, on buddy lists */ > > > +#define PG_readahead 20 /* Reminder to do readahead */ > > > > > > > Page flags are gouped by four, 20 would start a new set. > > Also in my tree (git from a few days ago), 20 is taken by PG_unchached. > > Thanks, grouped and renumbered it as 21. > > > What code is this patch-set against? > > It's against the latest -mm tree: linux-2.6.17-rc4-mm3.
Ah, now I see, -mm has got a trick up its sleeve for PG_uncached.
20 would indeed be the correct number for -mm. Then my sole comment would be the grouping, which is a stylish nit really.
Sorry for the confusion.
Peter
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |