lkml.org 
[lkml]   [2006]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps
Ingo Molnar wrote:
>
> static void print_fatal_signal(struct pt_regs *regs, int signr)
> {
> @@ -781,9 +870,13 @@ static void print_fatal_signal(struct pt
> printk("%02x ", insn);
> }
> }
> -#endif
> printk("\n");
> + if (current->mm)
> + printk("vDSO at %p\n", current->mm->context.vdso);
> +#endif
> show_regs(regs);
> + printk("\n");
> + print_vmas();
> }
>
> static int __init setup_print_fatal_signals(char *str

Perhaps I should have read your first patch more carefully - it did have
register info. This looks even better (although you may now want to
allow it to be #ifdef'd out under CONFIG_EMBEDDED).

You probably should use PATH_MAX+1 instead of SIZE or check IS_ERR() on
the string from d_path.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-24 00:28    [W:0.057 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site