lkml.org 
[lkml]   [2006]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: __vmalloc with GFP_ATOMIC causes 'sleeping from invalid context'
Nick Piggin wrote:
> Giridhar Pemmasani wrote:
>
>> On Mon, 22 May 2006 11:53:55 +1000, Nick Piggin
>> <nickpiggin@yahoo.com.au> said:
>>
>> > Giridhar Pemmasani wrote:
>> >> If __vmalloc is called in atomic context with GFP_ATOMIC flags,
>> >> __get_vm_area_node is called, which calls kmalloc_node with
>> >> GFP_KERNEL flags. This causes 'sleeping function called from
>> >> invalid context at mm/slab.c:2729' with 2.6.16-rc4 kernel. A
>> >> simple solution is to use
>>
>> > I can't see what would cause this in either 2.6.16-rc4 or
>> > 2.6.17-rc4. What is the line?
>>
>> If someone calls __vmalloc in atomic context (with GFP_ATOMIC flags):
>
>
> OK I misunderstood your comment. I was looking for the caller.
> Hmm, page_alloc.c does, but I don't know that it needs to be
> atomic -- what happens if we just make that allocation GFP_KERNEL?
>

OTOH, it doesn't seem to be particularly wrong to allow __vmalloc
GFP_ATOMIC allocations. The correct fix is to pass the gfp_mask
to kmalloc: if you're worried about breaking the API, introduce a
new __get_vm_area_node_mask() and implement __get_vm_area_node()
as a simple wrapper that passes in GFP_KERNEL.

Thanks,
Nick

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-22 08:13    [W:0.052 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site