lkml.org 
[lkml]   [2006]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] Have x86_64 use add_active_range() and free_area_init_nodes
On Sat, 20 May 2006, Andi Kleen wrote:

>
>> Anyway. From the implementation I can see what the code is doing. But I
>> see no description of what it is _supposed_ to be doing. (The process of
>> finding differences between these two things is known as "debugging"). I
>> could kludge things by setting MAX_ACTIVE_REGIONS to 1000000, but enough.
>> I look forward to the next version ;)
>
> Or we could just keep the working old code.
>
> Can somebody remind me what this patch kit was supposed to fix or
> improve again?
>

The current code for discovering the zone sizes and holes is sometimes
very hairy despite there being some similaries in each arch. This patch
kit will eliminiate some of the uglier code and have one place where zones
and holes can be sized. To me, that is a good idea once the bugs are
rattled out.

On a related note, parts of the current zone-based anti-fragmentation
implementation are an architecture-specific mess because changing how
zones are sized is tricky with the current code. With this patch kit,
sizing zones for easily reclaimable pages is relatively straight-forward.

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-21 18:23    [W:0.115 / U:3.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site