Messages in this thread | | | Date | Tue, 2 May 2006 22:15:35 +0200 | From | Alessandro Zummo <> | Subject | Re: [PATCH] RTC: rtc-dev UIE emulation |
| |
On Mon, 01 May 2006 23:32:42 +0900 (JST) Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Here is an updated patch. I think this one reflects all suggestions > by Andrew.
seems ok to me, just a few comments:
> + driver did not provides RTC_UIE ioctls. RTC_UIE is required > + by some programs, such as hwclock.
please fix the double spacing and s/provides/provide/
hwclock will be fixed to not rely on uie anymore anyway.
> +#ifdef CONFIG_RTC_INTF_DEV_UIE_EMUL > + INIT_WORK(&rtc->uie_task, rtc_uie_task, rtc); > + setup_timer(&rtc->uie_timer, rtc_uie_timer, (unsigned long)rtc); > + rtc->irq_active = 0; > + rtc->stop_uie_polling = 0; > + rtc->uie_task_active = 0; > + rtc->uie_timer_active = 0; > +#endif
the rtc struct is allocated via kzalloc, so you don't need to zero it.
--
Best regards,
Alessandro Zummo, Tower Technologies - Turin, Italy
http://www.towertech.it
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |