lkml.org 
[lkml]   [2006]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][-rt PATCH] Try to safely error out when mixing pi/non-pi futex operations on the same futex.

* john stultz <johnstul@us.ibm.com> wrote:

> Ingo,
> We've been seeing some oopses because there are waiters on pi
> futexes that do not have pi_states. This seems to be because they were
> used w/ futex_wait in one path and futex_lock_pi in another.

indeed, that's a bug.

> I'm told this shouldn't ever happen, but if it did, the kernel should
> safely error out, instead of oopsing or never releasing a lock.
>
> Not sure if this is a solid fix (it does build and boot), but
> hopefully it will stir up some discussion.

applied. I made some small fixes: i made the printk rate-limited and
dependent on CONFIG_DEBUG_RT_MUTEXES. The right thing is indeed to
-EINVAL.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-18 10:00    [W:0.029 / U:4.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site