lkml.org 
[lkml]   [2006]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add Amstrad Delta NAND support.
On Thu, 18 May 2006 17:09:41 +0100, Jonathan McDowell wrote:
>
> +static struct mtd_info *ams_delta_mtd = NULL;



> + switch(cmd){
^ ^
Add spaces

> + omap_writew(0, (OMAP_MPUIO_BASE + OMAP_MPUIO_IO_CNTL));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Could that be done in a macro?

> + udelay(0.04);

Floating point in the kernel?

> + ams_delta_mtd = kmalloc (sizeof(struct mtd_info) +
^
> + sizeof (struct nand_chip), GFP_KERNEL);

Remove space

And please create a structure containing both struct mtd_info and
struct nand_chip. Then use sizeof(that structure)...

> + /* Get pointer to private data */
> + this = (struct nand_chip *) (&ams_delta_mtd[1]);

...and remove this cast.

> + /* Initialize structures */
> + memset((char *) ams_delta_mtd, 0, sizeof(struct mtd_info));
> + memset((char *) this, 0, sizeof(struct nand_chip));

And those as well, while you're at it.

> + if (nand_scan (ams_delta_mtd, 1)) {
^
> + kfree (ams_delta_mtd);
^
> +static void __exit ams_delta_cleanup (void)
^
> + nand_release (ams_delta_mtd);
^
> + kfree (ams_delta_mtd);
^
Jörn

--
Happiness isn't having what you want, it's wanting what you have.
-- unknown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-18 19:00    [W:0.065 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site