Messages in this thread | | | Subject | Re: [PATCH] Fix do_mlock so page alignment is to hugepage boundries when needed | From | Eric Paris <> | Date | Wed, 17 May 2006 14:20:53 -0400 |
| |
On Wed, 2006-05-17 at 10:24 -0700, Christoph Lameter wrote: > On Wed, 17 May 2006, Eric Paris wrote: > > > --- linux-2.6.16.14/include/asm-sparc64/page.h.paris > > +++ linux-2.6.16.14/include/asm-sparc64/page.h > > @@ -104,6 +104,8 @@ typedef unsigned long pgprot_t; > > #define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) > > #define ARCH_HAS_SETCLEAR_HUGE_PTE > > #define ARCH_HAS_HUGETLB_PREFAULT_HOOK > > +/* to align the pointer to the (next) page boundary when dealing with hugepages*/ > > +#define HPAGE_ALIGN(addr) (((addr)+HPAGE_SIZE-1)&HPAGE_MASK) > > #endif > > Could you put the definition of HPAGE_ALIGN into include/linux/hugetlb.h > to avoid modifying all the page.h files?
I could, I was just following the example of PAGE_ALIGN which was in all the page.h files. But since it really is a nonarch specific hugepage only macro maybe that is a better place for it.
If other results come back positive I'll repost with that change if others think it best.
-Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |