lkml.org 
[lkml]   [2006]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix potential NULL pointer dereference in yam
    On Mon, May 15, 2006 at 10:19:36PM +0200, Jesper Juhl wrote:

    > > How can it be NULL here? The whole array of valid net_devices was
    > > allocated at module init time.
    > >
    >
    > It cannot. You are right, I'm wrong.
    > I guess removing the check makes sense then ?

    Yes.

    Acked-by: Ralf Baechle <ralf@linux-mips.org>

    > Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
    > ---
    >
    > --- linux-2.6.17-rc4-mm1-orig/drivers/net/hamradio/yam.c 2006-05-13 21:28:27.000000000 +0200
    > +++ linux-2.6.17-rc4-mm1/drivers/net/hamradio/yam.c 2006-05-15 22:16:32.000000000 +0200
    > @@ -852,7 +852,7 @@ static int yam_open(struct net_device *d
    >
    > printk(KERN_INFO "Trying %s at iobase 0x%lx irq %u\n", dev->name, dev->base_addr, dev->irq);
    >
    > - if (!dev || !yp->bitrate)
    > + if (!yp->bitrate)
    > return -ENXIO;
    > if (!dev->base_addr || dev->base_addr > 0x1000 - YAM_EXTENT ||
    > dev->irq < 2 || dev->irq > 15) {
    >

    73 de DL5RB op Ralf

    --
    Loc. JN47BS / CQ 14 / ITU 28 / DOK A21
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-16 12:01    [W:0.020 / U:210.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site