Messages in this thread | | | Subject | Re: [PATCH] fix race in inotify_release | From | John McCutchan <> | Date | Tue, 16 May 2006 15:54:40 -0400 |
| |
On Tue, 2006-05-16 at 15:39 -0400, Amy Griffis wrote: > While doing some inotify stress testing, I hit the following race. In > inotify_release(), it's possible for a watch to be removed from the > lists in between dropping dev->mutex and taking inode->inotify_mutex. > The reference we hold prevents the watch from being freed, but not > from being removed. > > Checking the dev's idr mapping will prevent a double list_del of the > same watch.
Looks good. Thanks for the patch and stress testing inotify!
-- John McCutchan <john@johnmccutchan.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |