lkml.org 
[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC 2.6.16.5 1/1] usb/media/quickcam_messenger driver v2
On 5/15/06, Oliver Neukum <oliver@neukum.name> wrote:
> Am Montag, 15. Mai 2006 10:49 schrieb jayakumar.video@gmail.com:
> > +urb->status = 0;
> > +urb->actual_length = 0;
>
> These are not needed. Indeed you should never write to those fields.
>
> Regards
> Oliver
>

I see. Good point. I ought to have actually looked at usb_submit_urb
and seen that it initializes status and actual_length. I'll make the
change.

To reduce my embarrassment, I'll point out that several other media
drivers also do this:

drivers/usb/media % egrep "urb->status.*=" *.c
<snip>
konicawc.c: urb->status = 0;
se401.c: urb->status=0;
stv680.c: urb->status = 0;
usbvideo.c: urb->status = 0;
w9968cf.c: urb->status = 0;

In most of the above cases, it appears to be just before resubmitting the urb.

Thanks,
jaya
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-15 14:53    [W:0.088 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site