lkml.org 
[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subject[-rt potential bug?] Bad error path in futex_wake
From
Date
Hey Ingo,
I've been trying to help Dinakar chase down a futex bug where
lookup_pi_state oopses due to this->pi_state being NULL
(kernel/futex.c:480).

No clue on why yet, but looking over the code, I noticed the following
odd error path:

static int futex_wake(u32 __user *uaddr, int nr_wake)
{
[snip]
down_read(&current->mm->mmap_sem);

ret = get_futex_key(uaddr, &key);
if (unlikely(ret != 0))
goto out;

hb = hash_futex(&key);
spin_lock(&hb->lock);
head = &hb->chain;

list_for_each_entry_safe(this, next, head, list) {
if (match_futex (&this->key, &key)) {
if (this->pi_state)
!!!!------> return -EINVAL;
wake_futex(this);
if (++ret >= nr_wake)
break;
}
}

spin_unlock(&hb->lock);
out:
up_read(&current->mm->mmap_sem);
return ret;
}

I'm not very familiar w/ the futex code, so this might be the right
thing, but it sure looks wrong.

Thoughts?

thanks
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-16 04:15    [W:0.038 / U:5.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site