Messages in this thread | | | Date | Tue, 16 May 2006 02:09:03 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH 2/3] moxa: remove pointless check of 'tty' argument vs NULL |
| |
On Mon, May 15, 2006 at 05:59:01PM -0400, Alan Cox wrote: > On Mon, May 15, 2006 at 11:57:35PM +0200, Jesper Juhl wrote: > > Remove pointless check of 'tty' argument vs NULL from moxa driver. > > Can you leave those in for the moment but change them to BUG_ON() because > I've seen the pop up once or twice. They may be fixed but Im not 100% sure > yet.
Dereference to get ->driver_data will show the very same backtrace?
struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
- if (!tty || !info->xmit_buf) > > + if (!info->xmit_buf) > > return (0);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |