lkml.org 
[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86 NUMA panic compile error

    * Andy Whitcroft <apw@shadowen.org> wrote:

    > if (use_cyclone == 0) {
    > /* Make sure user sees something */
    > - static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else."
    > + static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else.";
    > early_printk(s);
    > panic(s);
    > }

    i still strongly oppose the original Andi hack... numerous reasons were
    given not to apply it (it's nice to simulate/trigger rarer features on
    mainstream hardware too, and this ability to boot NUMA on my flat x86
    testbox found at least one other NUMA bug already). Furthermore, the
    crash i reported was fixed by the NUMA patchset. Andrew, please drop:

    x86_64-mm-i386-numa-summit-check.patch

    (which has nothing to do with x86_64 anyway)

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-15 19:55    [W:0.020 / U:2.676 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site