Messages in this thread Patch in this message | | | Date | Mon, 15 May 2006 11:54:56 -0400 | From | Florin Malita <> | Subject | [PATCH] jffs2: memory leak in jffs2_scan_medium() |
| |
If jffs2_scan_eraseblock() fails and the exit path is taken, 's' is not being deallocated.
Reported by Coverity, CID: 1258.
Signed-off-by: Florin Malita <fmalita@gmail.com> ---
diff --git a/fs/jffs2/scan.c b/fs/jffs2/scan.c index cf55b22..27a7021 100644 --- a/fs/jffs2/scan.c +++ b/fs/jffs2/scan.c @@ -222,9 +222,6 @@ #endif } } - if (jffs2_sum_active() && s) - kfree(s); - /* Nextblock dirty is always seen as wasted, because we cannot recycle it now */ if (c->nextblock && (c->nextblock->dirty_size)) { c->nextblock->wasted_size += c->nextblock->dirty_size; @@ -266,6 +263,8 @@ #ifndef __ECOS else c->mtd->unpoint(c->mtd, flashbuf, 0, c->mtd->size); #endif + kfree(s); + return ret; }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |