lkml.org 
[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ide_dma_speed() fixes
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>
> Hello.
>
> Andrew Morton wrote:
>
> >> ide_dma_speed() fails to actually honor the IDE drivers' mode support
> >> masks) because of the bogus checks -- thus, selecting the DMA transfer mode
> >> that the driver explicitly refuses to support is possible. Additionally, there
> >> is no check for validity of the UltraDMA mode data in the drive ID, and the
> >> function is misdocumented.
>
> > drivers/ide/ide-lib.c: In function `ide_dma_speed':
> > drivers/ide/ide-lib.c:86: warning: `ultra_mask' might be used uninitialized in this function
>
> > Looks like a real bug to me - it depends up on the values of `mode' and
> > id->field_value.
>
> > Anyway, I'll drop it, please review and fix. I assume that warning was
> > occurring for you as well - please spend more time over these things.
> > Especially when working on IDE, where bugs are slow to show themselves and
> > have particularly bad consequences.
>
> That's what gcc thinks. The code is 100% correct -- it will never reach
> the switch statement with mode > 0 (in which case ultra_mask isn't used) and
> ultra_mask unitialized.

hm, OK.

> I may add an explicit initializer in the declaration if you like...

Opinions vary. I think that's less bad than spitting a warning at all
developers for all time.

But we can redo things like below and save a little code in the process.
Look OK?

--- devel/drivers/ide/ide-lib.c~ide_dma_speed-fixes-warning-fix 2006-05-15 07:56:28.000000000 -0700
+++ devel-akpm/drivers/ide/ide-lib.c 2006-05-15 08:00:12.000000000 -0700
@@ -90,9 +90,9 @@ u8 ide_dma_speed(ide_drive_t *drive, u8
return 0;

/* Capable of UltraDMA modes? */
- if (id->field_valid & 4)
- ultra_mask = id->dma_ultra & hwif->ultra_mask;
- else
+ ultra_mask = id->dma_ultra & hwif->ultra_mask;
+
+ if (!(id->field_valid & 4))
mode = 0; /* fallback to MW/SW DMA if no UltraDMA */

switch (mode) {
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-15 17:06    [W:0.081 / U:3.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site