[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ide_dma_speed() fixes

Andrew Morton wrote:

>> ide_dma_speed() fails to actually honor the IDE drivers' mode support
>> masks) because of the bogus checks -- thus, selecting the DMA transfer mode
>> that the driver explicitly refuses to support is possible. Additionally, there
>> is no check for validity of the UltraDMA mode data in the drive ID, and the
>> function is misdocumented.

> drivers/ide/ide-lib.c: In function `ide_dma_speed':
> drivers/ide/ide-lib.c:86: warning: `ultra_mask' might be used uninitialized in this function

> Looks like a real bug to me - it depends up on the values of `mode' and
> id->field_value.

> Anyway, I'll drop it, please review and fix. I assume that warning was
> occurring for you as well - please spend more time over these things.
> Especially when working on IDE, where bugs are slow to show themselves and
> have particularly bad consequences.

That's what gcc thinks. The code is 100% correct -- it will never reach
the switch statement with mode > 0 (in which case ultra_mask isn't used) and
ultra_mask unitialized. I may add an explicit initializer in the declaration
if you like...

MBR, Sergei
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2006-05-15 15:48    [W:0.052 / U:25.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site