Messages in this thread | | | Date | Sun, 14 May 2006 12:44:25 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH -rt] scheduling while atomic in fs/file.c |
| |
On Sun, 14 May 2006, Daniel Walker wrote:
> Quite the smp_processor_id() wanrings. I don't see any SMP > concerns here . It just adds to a percpu list, so it shouldn't > matter if it switches after sampling fdtable_defer_list .
I'm not so sure that there isn't SMP concerns here. I have to catch a train in a few minutes, otherwise I would look deeper into this. But this might be a candidate to turn fdtable_defer_list into a per_cpu_locked.
-- Steve
> > Signed-Off-By: Daniel Walker <dwalker@mvista.com> > > Index: linux-2.6.16/fs/file.c > =================================================================== > --- linux-2.6.16.orig/fs/file.c > +++ linux-2.6.16/fs/file.c > @@ -138,6 +138,8 @@ static void free_fdtable_rcu(struct rcu_ > kfree(fdt); > } else { > fddef = &get_cpu_var(fdtable_defer_list); > + put_cpu_var(fdtable_defer_list); > + > spin_lock(&fddef->lock); > fdt->next = fddef->next; > fddef->next = fdt; > @@ -149,7 +151,6 @@ static void free_fdtable_rcu(struct rcu_ > if (!schedule_work(&fddef->wq)) > mod_timer(&fddef->timer, 5); > spin_unlock(&fddef->lock); > - put_cpu_var(fdtable_defer_list); > } > } > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |