Messages in this thread | | | Date | Fri, 12 May 2006 11:27:09 +0200 | From | "Thomas Kleffel (maintech GmbH)" <> | Subject | Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cards if IO space is not available (2nd revision) |
| |
David Vrabel wrote:
>Thomas Kleffel (maintech GmbH) wrote: > > >>+void outb_io(unsigned char value, unsigned long port) { >>+ outb(value, port); >>+} >>+ >>+void outb_mem(unsigned char value, unsigned long port) { >>+ writeb(value, (void __iomem *) port); >> } >> >> > >[...] > > > >>+ if(is_mmio) >>+ my_outb = outb_mem; >>+ else >>+ my_outb = outb_io; >> >> > > >Shouldn't you convert ide_cs to use iowrite8 (and friends) instead of >doing this? > > You're right. I didn't know about iowrite8.
I'll post a new revision soon.
Thomas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |