Messages in this thread | | | From | Michael Buesch <> | Subject | Re: [patch 2/6] New Generic HW RNG | Date | Wed, 10 May 2006 23:18:16 +0200 |
| |
On Wednesday 10 May 2006 22:57, you wrote: > On Sun, May 07, 2006 at 03:16:08PM +0200, Michael Buesch wrote: > > On Sunday 07 May 2006 15:03, you wrote: > > > > + list_for_each_entry(rng, &rng_list, list) { > > > > + if (strncmp(rng->name, buf, len) == 0) { > > > > > > This will match if the passed string is just a prefix of rng->name. > > > Apparently sysfs guarantees that the buffer passed to ->store will be > > > NUL-terminated, so this should be just a strcmp(). > > > > I am not sure if it is guaranteed NUL terminated. Greg? > > But I will look into this. > > Yes it will be.
Ok, very nice. I will resend the patches as soon as I have some time. I also splitted up the x86 drivers. Looks very good and clean now. ;)
-- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |