Messages in this thread | | | From | Alistair John Strachan <> | Subject | Re: [PATCH -mm] sys_semctl gcc 4.1 warning fix | Date | Wed, 10 May 2006 20:55:33 +0100 |
| |
On Wednesday 10 May 2006 17:37, Daniel Walker wrote: > On Wed, 2006-05-10 at 17:21 +0100, Al Viro wrote: > > Don't. Fix. Correct. Code. > > > > Ever. Because sooner or later you will paper over real bug. It's far > > better to reject patches that just make $TOOL to STFU than risk blind > > "fix" hiding a real bug. > > Couldn't agree with you more .. But I don't want to see the warning > either ..
Maybe adding "#warning GCC false-positive in this file, line blah." would be a suitable compromise. "Seeing" the bug isn't that big a deal, it's opening the file up to investigate it only to find it's been investigated a million times before and the same conclusions drawn..
-- Cheers, Alistair.
Third year Computer Science undergraduate. 1F2 55 South Clerk Street, Edinburgh, UK. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |