Messages in this thread | | | Subject | Re: [PATCH -mm] megaraid gcc 4.1 warning fix | From | Daniel Walker <> | Date | Wed, 10 May 2006 07:13:46 -0700 |
| |
On Wed, 2006-05-10 at 11:39 +0100, Alan Cox wrote: > On Maw, 2006-05-09 at 19:56 -0700, Daniel Walker wrote: > > Fixes the following warning, > > > > drivers/scsi/megaraid.c: In function ‘issue_scb’: > > drivers/scsi/megaraid.c:1153: warning: passing argument 2 of ‘writel’ makes pointer from integer without a cast > > And adds an exploitable memory leak. Please don't fix "bugs" blindly but > check that the error path still releases all the relevant resources.
I did nothing blindly .. I have a queue of 50+ more of these. I researched every error path , and made sure the warning wasn't an actual problem. If it was a problem , or I wasn't sure if the fix was 100% I sent it to LKML ..
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |