Messages in this thread | | | Date | Tue, 2 May 2006 04:11:18 +0400 | From | Oleg Nesterov <> | Subject | Re: splice(SPLICE_F_MOVE) problems |
| |
On 05/01, Jens Axboe wrote: > > > If readahead doesn't work, SPLICE_F_MOVE is problematic too. > > add_to_page_cache_lru()->lru_cache_add() first increments > > page->count and adds this page to lru_add_pvecs. This means > > page_cache_pipe_buf_steal()->remove_mapping() will probably > > fail. > > Because of the temporarily elevated page count?
Yes.
On the other hand, if readahead doesn't work we already have a bigger problem, and SPLICE_F_MOVE is not garanteed, so I think this is very minor.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |