Messages in this thread | | | Date | Mon, 1 May 2006 09:54:43 -0700 | From | Greg KH <> | Subject | Re: [ALSA] add __devinitdata to all pci_device_id |
| |
On Mon, May 01, 2006 at 06:49:24PM +0200, Arjan van de Ven wrote: > On Mon, 2006-05-01 at 15:11 +0000, Linux Kernel Mailing List wrote: > > commit 396c9b928d5c24775846a161a8191dcc1ea4971f > > tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade > > parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce > > author Henrik Kretzschmar <henne@nachtwindheim.de> Mon, 24 Apr 2006 15:59:04 +0200 > > committer Jaroslav Kysela <perex@suse.cz> Thu, 27 Apr 2006 21:10:34 +0200 > > > > [ALSA] add __devinitdata to all pci_device_id > > > are you really really sure you want to do this? > These structures are exported via sysfs for example, I would think this > is quite the wrong thing to make go away silently...
I asked Henrik to not do this, but oh well...
No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then the sysfs stuff is enabled. And since CONFIG_HOTPLUG is pretty much always enabled these days, the savings of this kind of patch is non-existant...
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |