Messages in this thread | | | Date | Mon, 1 May 2006 10:56:32 -0400 (EDT) | From | James Morris <> | Subject | Re: [PATCH 4/4] MultiAdmin module |
| |
On Mon, 1 May 2006, Jan Engelhardt wrote:
> +#if !defined(CONFIG_SECURITY_CAPABILITIES) && \ > + !defined(CONFIG_SECURITY_CAPABILITIES_MODULE) > +# error You need to have CONFIG_SECURITY_CAPABILITIES=y or =m \ > + for MultiAdmin to compile successfully. > +#endif
This is what Kconfig language is for.
> +typedef int bool;
You won't get much worthwile review of this code until you clean it up and make it conform to kernel coding style.
- James -- James Morris <jmorris@namei.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |