Messages in this thread | | | Date | Mon, 1 May 2006 18:19:01 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH] CodingStyle: add typedefs chapter |
| |
On Mon, May 01, 2006 at 04:00:09PM +0200, Jan Engelhardt wrote: > >+Please don't use things like "vps_t". > >+It's a _mistake_ to use typedef for structures and pointers. When you see a > >+ vps_t a; > >+in the source, what does it mean? > >+In contrast, if it says > >+ struct virtual_container *a; > >+you can actually tell what "a" is. > >+ > >+Lots of people think that typedefs "help readability". Not so. They are > >+useful only for: > [...] > > What about task_t vs struct task_struct? Both are used in the kernel.
task_t => struct task struct task_struct => struct task
Roughly 2765 hits :-\
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |