lkml.org 
[lkml]   [2006]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH/RFC] Requested changelog for minix filesystem update to V3
    Hi Jesper,

    just a comment below :

    On Mon, May 01, 2006 at 03:06:49PM +0200, Jesper Juhl wrote:
    > On 5/1/06, Daniel Aragonés <danarag@gmail.com> wrote:
    [snip]

    > >- i = ((numbits-(numblocks-1)*BLOCK_SIZE*8)/16)*2;
    > >+ i = ((numbits-(numblocks-1)*bh->b_size*8)/16)*2;
    >
    > A few more spaces please :
    >
    > i = ((numbits-(numblocks-1) * bh->b_size * 8) / 16) * 2;

    This spacing is still wrong, because I first read it like this :

    i = (((numbits-(numblocks-1)) * bh->b_size * 8) / 16) * 2;

    While in fact it's :

    i = ((numbits-((numblocks-1) * bh->b_size * 8)) / 16) * 2;

    Strictly speaking, this should be written this way :

    i = ((numbits - (numblocks - 1) * bh->b_size * 8) / 16) * 2;

    Or at least :

    i = ((numbits - (numblocks-1) * bh->b_size * 8) / 16) * 2;

    Anyway, it's a good sign when only spaces are being discussed on a piece
    of code ;-)

    Cheers,
    Willy

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-01 15:46    [W:0.040 / U:30.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site