Messages in this thread | | | Date | Sun, 09 Apr 2006 11:51:33 +1000 | From | Nick Piggin <> | Subject | Re: Userland swsusp failure (mm-related) |
| |
Rafael J. Wysocki wrote: > Hi, >
>>>Well, it looks like we didn't free enough RAM for suspend in this case. >>>Unfortunately we were below the min watermark for ZONE_NORMAL and >>>we tried to allocate with GFP_ATOMIC (Nick, shouldn't we fall back to >>>ZONE_DMA in this case?). >>> >>>I think we can safely ignore the watermarks in swsusp, so probably >>>we can set PF_MEMALLOC for the current task temporarily and reset >>>it when we have allocated memory. Pavel, what do you think? >> >>Seems little hacky but okay to me. >> >>Should not fixing "how much to free" computation to free a bit more be >>enough to handle this? > > > Yes, but in that case we'll leave some memory unused. ;-) >
Probably doesn't fall back to ZONE_DMA because of lowmem reserve. Yes, PF_MEMALLOC sounds like it might do what you want. A little hackish perhaps, but better than putting swsusp special cases into page_alloc.c.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |