Messages in this thread | | | From | Bodo Eggert <> | Subject | Re: + git-klibc-mktemp-fix.patch added to -mm tree | Date | Sun, 09 Apr 2006 01:34:42 +0200 |
| |
Sam Ravnborg <sam@ravnborg.org> wrote: > On Sat, Apr 08, 2006 at 12:05:54AM -0700, akpm@osdl.org wrote:
>> diff -puN usr/dash/mkbuiltins~git-klibc-mktemp-fix usr/dash/mkbuiltins >> --- 25/usr/dash/mkbuiltins~git-klibc-mktemp-fix Sat Apr 8 14:51:11 2006 >> +++ 25-akpm/usr/dash/mkbuiltins Sat Apr 8 14:51:11 2006
>> - tempfile=mktemp >> + tempfile="mktemp /tmp/tmp.XXXXXX" > > Shouldn't that be: >> + tempfile="$(mktemp /tmp/tmp.XXXXXX)"
No. You should use tempfile="$(mktemp ${TMPDIR:-/tmp}/tmp.XXXXXX)" (or mktemp -t, if it's portable enough)
Besides that, tmp.XXXXXX should be replayed using a better name.
</nitpick> -- Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF verbreiteten Lügen zu sabotieren. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |