Messages in this thread | | | Date | Thu, 06 Apr 2006 09:49:55 +0800 | From | "Antonino A. Daplas" <> | Subject | Re: 2.6.17-rc1-mm1 |
| |
Bjorn Helgaas wrote: > On Wednesday 05 April 2006 15:17, Luck, Tony wrote: >> On Wed, Apr 05, 2006 at 10:15:34AM -0600, Bjorn Helgaas wrote:
> [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use > > VGA_MAP_MEM translates to ioremap() on some architectures. It > makes sense to do this to vga_vram_base, because we're going to > access memory between vga_vram_base and vga_vram_end. > > But it doesn't really make sense to map starting at vga_vram_end, > because we aren't going to access memory starting there. On ia64, > which always has to be different, ioremapping vga_vram_end gives > you something completely incompatible with ioremapped vga_vram_start, > so vga_vram_size ends up being nonsense. > > As a bonus, we often know the size up front, so we can use ioremap() > correctly, rather than giving it a zero size.
I definitely prefer this patch.
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Acked-by: Antonino Daplas <adaplas@pol.net>
Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |