Messages in this thread | | | Date | Thu, 6 Apr 2006 00:12:29 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] modules_install must not remove existing modules |
| |
On Wed, Apr 05, 2006 at 11:33:50PM +0200, Andreas Gruenbacher wrote: > When installing external modules with `make modules_install', the > first thing that happens is a rm -rf of the target directory. This > works only once, and breaks when installing more than one (set of) > external module(s). Bug introduced in: > http://www.kernel.org/hg/linux-2.6/?cs=bbb3915836f5 > > Sam, is this fix okay with you? The removal was introduced to get rid of old modules from an earlier build of the same kernel with potential more modules. I was obvious when I played with an allmodconfig kernel IIRC.
The usecase you have in mind is with external modules only? We could special case in that suation and avoid the removal.
I see no way to detect when it is OK to remove or not, so in the principle of least suprise I prefer having the removal unconditional for normal kernel builds, and no removal for external modules.
OK?
Sam
> > Signed-off-by: Andreas Gruenbacher <agruen@suse.de> > > Index: linux-2.6.16/Makefile > =================================================================== > --- linux-2.6.16.orig/Makefile > +++ linux-2.6.16/Makefile > @@ -1131,7 +1131,6 @@ modules_install: _emodinst_ _emodinst_po > install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra) > .PHONY: _emodinst_ > _emodinst_: > - $(Q)rm -rf $(MODLIB)/$(install-dir) > $(Q)mkdir -p $(MODLIB)/$(install-dir) > $(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.modinst > > -- > Andreas Gruenbacher <agruen@suse.de> > Novell / SUSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |