Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree | Date | Tue, 4 Apr 2006 21:59:12 -0400 |
| |
On Tuesday 04 April 2006 17:45, Greg KH wrote: > > But why do we do that? probe() failing is driver's problem. The device > > is still there and should still be presented in sysfs. I don't think > > that we should stop if probe() fails - maybe next driver manages to > > bind itself. > > The device is still there. > > Ah, I see what you are saying now. Yeah, we should still add the > default attributes for the bus and create the bus link even if some > random driver had problems.
Not only that, but device will be killed as well - if bus_add_device() fails device_add() branches into BusError which leads to kobject_del().
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |