Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: patch bus_add_device-losing-an-error-return-from-the-probe-method.patch added to gregkh-2.6 tree | Date | Tue, 4 Apr 2006 21:48:56 -0400 |
| |
On Tuesday 04 April 2006 18:12, Rene Herman wrote: > To Dmitry, I see you saying "probe() failing is driver's problem. The > device is still there and should still be presented in sysfs.". No, at > least in the case of these platform drivers (or at least these old ISA > cards using the platform driver interface), a -ENODEV return from the > probe() method would mean the device is _not_ present (or not found at > least). NODEV.
Or you could separate device probing code from driver->probe(). BTW I think that ->probe() is not the best name for that method. It really is supposed to allocate resources and initialize the device so that it is ready to be used, not to verify that device is present. The code that created device shoudl've done that.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |