Messages in this thread Patch in this message | | | Date | Mon, 3 Apr 2006 18:52:06 -0500 | From | Dave Jones <> | Subject | potential null dereference in splice code. |
| |
We can get to out: with a NULL page, which we probably don't want to be calling page_cache_release() on.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.16.noarch/fs/splice.c~ 2006-04-03 18:47:40.000000000 -0500 +++ linux-2.6.16.noarch/fs/splice.c 2006-04-03 18:50:06.000000000 -0500 @@ -445,7 +445,7 @@ find_page: ret = -ENOMEM; page = find_or_create_page(mapping, index, gfp_mask); if (!page) - goto out; + goto out_nomem; /* * If the page is uptodate, it is also locked. If it isn't @@ -507,6 +507,7 @@ out: page_cache_release(page); unlock_page(page); } +out_nomem: buf->ops->unmap(info, buf); return ret; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |