Messages in this thread | | | Date | Mon, 3 Apr 2006 20:44:48 +0100 | From | Russell King <> | Subject | Re: [PATCH 2.6.17-rc1] [SERIAL] DCC(JTAG) serial and the console emulation support(revised#2) |
| |
On Mon, Apr 03, 2006 at 08:24:10PM +0900, Hyok S. Choi wrote:
The number of comments is getting smaller. Only two remaining.
> + help > + Say Y here if you want to install DCC driver as a normal serial port > + /dev/ttyS0 (major 4, minor 64). Otherwise, it appears as /dev/ttyJ0 > + (major 4, minor 128) and can co-exist with other UARTs, such as > + 8250/16C550 compatibles.
Help doesn't match code.
> +static void dcc_shutdown(struct uart_port *port) > +{ > +#ifdef DCC_IRQ_USED /* real IRQ used */ > + free_irq(port->irq, port); > +#else > + spin_lock(&port->lock); > + cancel_rearming_delayed_work(&dcc_poll_task);
cancel_rearming_delayed_work() might sleep due to it calling flush_workqueue. Therefore, you must not be holding a spinlock.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |