Messages in this thread | | | Date | Mon, 3 Apr 2006 10:42:02 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: Fw: 2.6.16 crashes when running numastat on p575 |
| |
On Mon, 3 Apr 2006, Nathan Lynch wrote:
> In this case, disabling preempt around the for_each_online_cpu loop > would prevent any cpu from going down in the meantime. But since this > function doesn't look like it's a hot path, and we're potentially > traversing lots of zones and cpus, lock_cpu_hotplug might be preferable. > > As Paul noted, the fix as it stands isn't adequate.
There are many other for_each_*_cpu loops in the kernel that do not have any of the instrumentation you suggest. I suggest you come up with a general solution and then go through all of them and fix this. Please be aware that many of these loops are performance critical. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |