Messages in this thread | | | Date | Wed, 26 Apr 2006 11:16:17 +0300 (EEST) | From | Pekka J Enberg <> | Subject | Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL) |
| |
On 4/25/06, Hua Zhong <hzhong@gmail.com> wrote: > > > diff --git a/mm/slab.c b/mm/slab.c > > > index e6ef9bd..0fbc854 100644 > > > --- a/mm/slab.c > > > +++ b/mm/slab.c > > > @@ -3380,7 +3380,7 @@ void kfree(const void *objp) > > > struct kmem_cache *c; > > > unsigned long flags; > > > > > > - if (unlikely(!objp)) > > > + if (!objp) > > > return;
> On Wed, 2006-04-26 at 10:30 +0300, Pekka Enberg wrote: > > NAK. Fix the callers instead.
On Wed, 26 Apr 2006, Arjan van de Ven wrote: > eh dude... they are being fixed... to remove the NULL check :)
Most of which are on error paths. The problem we're seeing is in handful of fastpath offenders which should be fixed either by re-design or adding the NULL check along with a big fat comment like Andrew is doing.
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |