Messages in this thread | | | Date | Wed, 26 Apr 2006 22:48:09 +0200 | From | "Steinar H. Gunderson" <> | Subject | Re: [PATCH] Remove softlockup from invalidate_mapping_pages. |
| |
On Thu, Apr 20, 2006 at 12:38:39AM -0700, Andrew Morton wrote: > In practice, I think it's OK - there's no _reason_ why anyone would want to > trash the ->index of a just-truncated page. However I think it'd be saner > to a) only look at ->index after we've tried to lock the page and b) make > sure that ->index is really "to the right" of where we're currently at. > > How's this look? > > --- devel/mm/truncate.c~remove-softlockup-from-invalidate_mapping_pages 2006-04-20 00:20:49.000000000 -0700 > +++ devel-akpm/mm/truncate.c 2006-04-20 00:28:18.000000000 -0700
I tried this patch against 2.6.17-rc2 (I hoped that it might be fixing my kswapd oopses too, as they seem related; see http://lkml.org/lkml/2006/4/26/124 and followups), and it simply makes my machine hang on bootup -- it seems to make modprobe hang forever on some lock or something right after it loads raid6.ko (pulled in by evms_activate) in initramfs. Without the patch, the machine boots just fine.
Since it's on serial console, I've got a SysRq+T log if it helps you.
/* Steinar */ -- Homepage: http://www.sesse.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |