lkml.org 
[lkml]   [2006]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git patch] fuse fixes
    Miklos Szeredi wrote:
    > Linus,
    >
    > Please pull from 'for-linus' branch of
    > master.kernel.org:/pub/scm/linux/kernel/git/mszeredi/fuse.git

    Reading the code...
    > struct fuse_req *fuse_request_alloc(void)
    > {
    > struct fuse_req *req = kmem_cache_alloc(fuse_req_cachep, SLAB_KERNEL);
    > if (req)
    > fuse_request_init(req);
    > return req;
    > }

    This function is called from everywhere, and so, it looks like it should
    use SLAB_NOFS rather than SLAB_KERNEL. I would audit every GFP_KERNEL
    and SLAB_KERNEL usage, and consider replacing with SLAB_NOFS or GFP_NOFS.

    Jeff


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-26 22:05    [W:0.024 / U:0.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site