Messages in this thread | | | Date | Tue, 25 Apr 2006 17:24:31 -0700 | From | Greg KH <> | Subject | Re: [patch 2/2] kref: kref debugging config option |
| |
On Tue, Apr 25, 2006 at 04:21:39PM +0800, Akinobu Mita wrote: > - WARN_ON(atomic_read(&kref->refcount) < 1); > - WARN_ON(release == NULL); > - WARN_ON(release == (void (*)(struct kref *))kfree);
No, those two last WARN_ON() are not "debugging" checks, they are "checks for people trying to do bad things with kref code". I always want them "on", as there should not be any excuse for anyone to do this.
So I don't think this patch is needed at all.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |