lkml.org 
[lkml]   [2006]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Profile likely/unlikely macros
From
Date
On Tue, 2006-04-25 at 20:11 +1000, Nick Piggin wrote:

> I guess it is so it can be used in NMIs and interrupts without turning
> interrupts off (so is somewhat lightweight).
>
> But please Daniel, just use spinlocks and trylock. This is buggy because
> it doesn't get the required release consistency correct.


To use spinlock we would need to used the __raw_ types . As Hua
explained all of the vanilla spinlock calls use the unlikely macro. The
result is that we end up using atomic operations. So using them directly
seems like the cleanest method .

I'm not exactly sure what you mean by "release consistency" ?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-25 20:26    [W:0.081 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site