Messages in this thread | | | Date | Tue, 25 Apr 2006 00:30:03 +0200 | From | Willy Tarreau <> | Subject | Re: Compiling C++ modules |
| |
On Tue, Apr 25, 2006 at 12:09:01AM +0200, Martin Mares wrote: > Hello! > > > Oh, and yeah, a = b + c *is* more readable than > > > > a = malloc(strlen(b) + strlen(c)); > > strcpy(a,b); > > strcat(a,c); > > > > and contains fewer bugs ;) > > Actually, it contains at least the bug you have made in your C example, > that is forgetting that malloc() can fail. So can string addition, if > allocated dynamically.
And if it does not fail, it may overflow because he forgot one char in the malloc(). Anyway, I still prefer the C form, at least I know what it does.
Cheers, Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |