Messages in this thread | | | Date | Fri, 21 Apr 2006 01:02:44 -0700 | From | Andrew Morton <> | Subject | Re: [patch 1/5] mm: remap_vmalloc_range |
| |
Nick Piggin <npiggin@suse.de> wrote: > > > > > - are vma->vm_start and vma->vm_end always a multiple of PAGE_SIZE? (I > > always forget). If not, remap_valloc_range() looks a tad buggy. > > I hope so.
do_mmap_pgoff() seems to dtrt. It makes one wonder why vm_start and vm_end aren't in units of PAGE_SIZE.
> > > > - remap_valloc_range() would lose a whole buncha typecasts if you use the > > gcc pointer-arith-with-void* extension. > > Should I?
Well it's a gccism, and a good one. We have lots of gccisms and using this one here will neaten things up. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |