lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5] mm: remap_vmalloc_range
Nick Piggin <npiggin@suse.de> wrote:
>
> >
> > - are vma->vm_start and vma->vm_end always a multiple of PAGE_SIZE? (I
> > always forget). If not, remap_valloc_range() looks a tad buggy.
>
> I hope so.

do_mmap_pgoff() seems to dtrt. It makes one wonder why vm_start and vm_end
aren't in units of PAGE_SIZE.

> >
> > - remap_valloc_range() would lose a whole buncha typecasts if you use the
> > gcc pointer-arith-with-void* extension.
>
> Should I?

Well it's a gccism, and a good one. We have lots of gccisms and using this
one here will neaten things up.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-21 10:06    [W:0.037 / U:1.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site