lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] X86_NUMAQ build fix
From
Date
On Sat, 2006-04-22 at 03:50 +0900, OGAWA Hirofumi wrote:
> Dave Hansen <haveblue@us.ibm.com> writes:
> >> pci-y := fixup.o
> >> -pci-$(CONFIG_ACPI) += acpi.o
> >> pci-y += legacy.o irq.o
> >>
> >> pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
> >> pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
> >>
> >> +pci-$(CONFIG_ACPI) += acpi.o
> >
> > Am I reading this wrong, or does this just move the option down a bit?
> > Did you need to change the link order? Why?
>
> No, this is not link order. Note that CONFIG_X86_VISWS/CONFIG_X86_NUMAQ
> uses ":=", not "+=". In case of ACPI=y", it breaks build.

Ahh, so NUMAQ and VISWS don't seem to allow or want ACPI code.
Especially for the NUMAQ, I don't think we should even mess with this
too much. Just fix it in the build system and directly disallow NUMAQ
&& ACPI.

We already have this:

menu "ACPI (Advanced Configuration and Power Interface) Support"
depends on !X86_VISWS

Just add the NUMAQ in there, too.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-21 21:02    [W:0.068 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site