lkml.org 
[lkml]   [2006]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] FS-Cache: CacheFiles: A cache that backs onto a mounted filesystem
    David Howells <dhowells@redhat.com> wrote:
    >
    > + /* let keventd have some air occasionally */
    > + max--;
    > + if (max < 0 || need_resched()) {
    > + if (!list_empty(&object->read_list))
    > + schedule_work(&object->read_work);
    > + _leave(" [maxed out]");
    > + return;
    > + }

    That's perhaps not a terribly effective way of multiplexing keventd cycles.
    If someone has done a schedule_work(), that will stick an entry onto
    keventd's worklist, but it won't necessarily set need_resched().

    We'd need to extend the workqueue API to be able to determine whether
    there's other work pending.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-21 03:01    [W:0.021 / U:1.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site