[lkml]   [2006]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [Patch: 003/006] pgdat allocation for new node add (generic alloc node_data)
    > Yasunori Goto <> wrote:
    > >
    > > +#define generic_alloc_nodedata(nid) \
    > > +({ \
    > > + (pg_data_t *)kzalloc(sizeof(pg_data_t), GFP_KERNEL); \
    > > +})
    > In general, library functions which perform memory allocation should not
    > make assumptions about which gfp_t they are allowed to use.
    > So this really should be `generic_alloc_nodedata(nid, gfp_mask)'.
    > However, it's very desirable that memory allocations use GFP_KERNEL rather
    > than, say, GFP_ATOMIC. So your interface here _forces_ callers to be in a
    > state where GFP_KERNEL is legal, which is good discipline.
    > Although if that turns out to be a problem, we can expect to see a sad
    > little patch from someone which tries to change this to GFP_ATOMIC, which
    > makes everything worse - even those callers who _can_ use GFP_KERNEL.
    > (In practice, NUMA developers seem to never test with sufficient
    > CONFIG_DEBUG_* flags enabled, and with CONFIG_PREEMPT, so they happily
    > don't get to discover their sleep-in-spinlock bugs anyway).
    > Anyway, on balance, I think it'd be best to convert this API to take a
    > gfp_t as well.

    To tell the truth, I prefer making new interface to allocate new added
    memory than using normal kzalloc().
    Because this kzalloc() will allocate() other node's memory
    by im-completion new memory's initialization.

    In addition, memory hot-add may be required at the time that memory
    is already exhausted.
    This kzalloc() might be "finish blow". (pgdat is not small.
    Especially, ia64 needs node data's copy.)
    Probably, user will feel very strange.
    "I added new memory. But OOM killer is called by it, why????"

    So I think alloc_hot_added_memory() is desirable, which can allocate new
    added memory until completion of initialization.

    Thanks for your advice.

    Yasunori Goto

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-04-21 02:26    [W:0.021 / U:5.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site