lkml.org 
[lkml]   [2006]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 Patch] isdn4linux: Siemens Gigaset base driver: fix disconnect handling
    On Thu, Apr 20, 2006 at 08:21:20AM -0700, Randy.Dunlap wrote:
    > On Thu, 20 Apr 2006 14:07:11 +0200 Tilman Schmidt wrote:
    >
    > > On 20.04.2006 09:11, Andrew Morton wrote:
    > > > Tilman Schmidt <tilman@imap.cc> wrote:
    > > >
    > > >>This patch fixes a possible Oops in the Siemens Gigaset base driver when
    > > >> the device is unplugged while an ISDN connection is still active, and
    > > >> makes sure that the isdn4linux link level (LL) is properly informed if a
    > > >> connection is broken by the USB cable being unplugged.
    > > >> It also improves some kernel messages generated by the driver.
    > > >
    > > > It seems to do quite a lot more than that.
    > > > [...] I'd ask you to confirm that this was actually the patch which
    > > > was supposed to go with that changelog.
    > >
    > > It is. However the changelog was not quite complete. There were a couple
    > > of smaller changes which I neglected to mention. Sorry for that. I'll
    > > try to be more careful when composing future changelogs.
    >
    > ...
    >
    > > >> --- linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c 2006-04-19 15:15:49.000000000 +0200
    > > >> +++ local/drivers/isdn/gigaset/bas-gigaset.c 2006-04-19 01:19:41.000000000 +0200
    > > >
    > > > eek, please don't do that - it confuses my scripts.
    > > >
    > > > --- linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c
    > > > +++ linux-2.6.17-rc2-work/drivers/isdn/gigaset/bas-gigaset.c
    > > >
    > > > is preferred. There are nice tools around which help with this.
    > >
    > > I'll be happy to comply with whatever your scripts need, but I don't
    > > quite understand yet what it is that's causing you problems:
    > > The presence of file timestamps?
    > > The timestamp of the second file being earlier than the first one?
    > > The ".orig" suffix in the first path?
    > > The second path starting with "local" instead of "linux-..."?
    > > All of this can be easily corrected; just tell me what's required.
    >
    > Both filename lines should begin one level above "drivers/".
    > They can be named linux* or a/ and b/ or foo/ and bar/ or whatever.
    > The patch needs to apply using "patch -p1".
    >...

    His patch already was nearly correct.

    The only thing that is wrong is
    linux-2.6.17-rc2-work/drivers/isdn/gigaset.orig/bas-gigaset.c
    ^^^^^
    If anything else confused Andrew's scripts, he'd better fix his scripts.

    > ~Randy

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-04-20 17:35    [W:0.022 / U:0.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site