lkml.org 
[lkml]   [2006]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/4] UEAGLE : memory leack fix
matthieu castet wrote:
> Hi,
>
> this patch fix leak of memory allocated to intr if allocation of
> sc->urb_int fails.
> Found by the Coverity checker.
>
add correct path for the file name
Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>

Index: ueagle-atm.c
===================================================================
--- linux-2.6.15.old/drivers/usb/atm/ueagle-atm.c (rvision 266)
+++ linux-2.6.15/drivers/usb/atm/ueagle-atm.c (rvision 267)
@@ -1376,7 +1376,7 @@
if (ret < 0) {
uea_err(INS_TO_USBDEV(sc),
"urb submition failed with error %d\n", ret);
- goto err1;
+ goto err;
}

sc->kthread = kthread_run(uea_kthread, sc, "ueagle-atm");
@@ -1390,10 +1390,10 @@

err2:
usb_kill_urb(sc->urb_int);
-err1:
- kfree(intr);
err:
usb_free_urb(sc->urb_int);
+ sc->urb_int = NULL;
+ kfree(intr);
uea_leaves(INS_TO_USBDEV(sc));
return -ENOMEM;
}
\
 
 \ /
  Last update: 2006-04-03 14:39    [from the cache]
©2003-2011 Jasper Spaans