Messages in this thread | | | Date | Sun, 02 Apr 2006 11:35:53 +1000 | From | Nick Piggin <> | Subject | Re: [PATCH 2.6.16-mm2 1/4] sched_domain - handle kmalloc failure |
| |
Srivatsa Vaddagiri wrote: > Andrew/Nick/Ingo, > Here's a different version of the patch that tries to handle mem > allocation failures in build_sched_domains by bailing out and cleaning up > thus-far allocated memory. The patch has a direct consequence that we disable > load balancing completely (even at sibling level) upon *any* memory allocation > failure. Is that acceptable? >
I guess so. Ideal solution would be to make all required allocations first, then fail the build_sched_domains and fall back to the old structure. But I guess that gets pretty complicated.
In reality (and after your patch 2/4), I don't think the page allocator will ever fail any of these allocations. In that case, would it be simpler just to add a __GFP_NOFAIL here and forget about it?
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |