Messages in this thread | | | Date | Wed, 19 Apr 2006 16:49:59 -0500 | From | Matt Mackall <> | Subject | Re: sata suspend resume ... |
| |
On Wed, Apr 19, 2006 at 05:13:27PM +0100, Hugh Dickins wrote: > On Wed, 19 Apr 2006, Jeff Chua wrote: > > > > Any change of getting suspend/resume to work on my IBM X60s notebook. > > > > Disk model is ... > > > > MODEL="ATA HTS541060G9SA00" > > FW_REV="MB3I" > > > > Linux 2.6.17-rc2. > > > > System suspends ok. Resume ok. but no disk access after that. > > Not the same disk model, but I've been having similar trouble on a T43p. > > I was delighted to see the MSI suspend/resume fix go into 2.6.17-rc2, > but then disappointed. A bisection found that Matt Mackall's sensible > rc1 patch, to speed up get_cmos_time, has removed what often used to be > a 2 second delay in resuming: things work well when I reinstate that > delay (1 second has proved not enough). Below is the patch I'm using - > where I've failed to resist mucking around to avoid those double calls > to get_cmos_time, sorry: really it's just mdelay(2000) needed somewhere > (until someone who knows puts in something more scientific).
That's interesting.
Just to be clear, with my changes we should never fire timers early. Is the problem that we have a timer that didn't get deleted at suspend time?
-- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |